Nosial/configlib
2
0
Fork 0
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions 1

Environment-based configuration files not being loaded correctly #1

New issue
Closed
opened 2023-07-12 02:22:29 +00:00 by netkas · 4 comments
netkas commented 2023-07-12 02:22:29 +00:00 (Migrated from git-old.n64.cc)
Copy link

Configuration library is not correctly handling the environment variables, which leads to incorrect file paths being used when loading configuration files. This resulted in warnings being issued that configuration files did not exist, even when the correct paths were provided via environment variables.

Configuration library is not correctly handling the environment variables, which leads to incorrect file paths being used when loading configuration files. This resulted in warnings being issued that configuration files did not exist, even when the correct paths were provided via environment variables.
netkas commented 2023-07-12 02:22:30 +00:00 (Migrated from git-old.n64.cc)
Copy link

assigned to @netkas

assigned to @netkas
netkas commented 2023-07-12 02:23:48 +00:00 (Migrated from git-old.n64.cc)
Copy link

The Configuration->__construct() method was sanitizing the name of the configuration to be used and fetching the corresponding environment variable correctly. However, it was then using the name of the environment variable, rather than its value, when checking if the configuration file existed and when setting the path to the configuration file.

The bug has been fixed by using the value of the environment variable, rather than its name, when checking if the configuration file exists and when setting the path to the configuration file. The affected lines of code are within the Configuration->__construct() method.

The `Configuration->__construct()` method was sanitizing the name of the configuration to be used and fetching the corresponding environment variable correctly. However, it was then using the name of the environment variable, rather than its value, when checking if the configuration file existed and when setting the path to the configuration file. The bug has been fixed by using the value of the environment variable, rather than its name, when checking if the configuration file exists and when setting the path to the configuration file. The affected lines of code are within the `Configuration->__construct()` method.
netkas commented 2023-07-12 02:26:00 +00:00 (Migrated from git-old.n64.cc)
Copy link

mentioned in commit a3c04e1c36

mentioned in commit a3c04e1c3623d9441d0478aa43a2ca1801107669
netkas (Migrated from git-old.n64.cc) closed this issue 2023-07-12 02:26:34 +00:00
netkas commented 2023-07-13 21:05:42 +00:00 (Migrated from git-old.n64.cc)
Copy link

mentioned in commit 5afae885db

mentioned in commit 5afae885db983b5bc910e6101f86ab9d64f88dc0
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
1.1.2
dev
1.1.7
1.1.6
1.1.5
1.1.3
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
Labels
Clear labels   
Bug

An unexpected behavior that needs to be corrected

  
Cannot Resolve

The issue cannot be resolved

  
Completed

The task has been completed

  
Enhancement

An enhancement that can be used to improve

  
Important

This issue is important

  
Question

A question about the project or usage of one of it's functions

  
Resolved

The issue has been resolved and is closed

  
Security Issue

A critical security issue that needs to be corrected as soon as possible

  
Suggestion

A suggestion that maintainers should implement or correct

  
Todo

A task that needs to be completed or is planned to be completed

No labels
Bug
Cannot Resolve
Completed
Enhancement
Important
Question
Resolved
Security Issue
Suggestion
Todo
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Nosial/configlib#1
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?