From dd78dccab25360afb9d54b591a879cfba9a25c9a Mon Sep 17 00:00:00 2001 From: netkas Date: Mon, 28 Oct 2024 19:59:34 -0400 Subject: [PATCH] Refactor directory creation error handling --- src/LogLib/Handlers/FileLogging.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/LogLib/Handlers/FileLogging.php b/src/LogLib/Handlers/FileLogging.php index dce2174..c62dff6 100644 --- a/src/LogLib/Handlers/FileLogging.php +++ b/src/LogLib/Handlers/FileLogging.php @@ -85,14 +85,12 @@ class FileLogging implements LogHandlerInterface { $logging_directory = $application->getFileLoggingDirectory(); - if(!is_writable($logging_directory)) - { - throw new RuntimeException(sprintf("Cannot write to %s due to insufficient permissions", $logging_directory)); - } - if(!file_exists($logging_directory)) { - mkdir($logging_directory); + if(!mkdir($logging_directory)) + { + throw new RuntimeException(sprintf("Cannot write to %s due to insufficient permissions", $logging_directory)); + } } $logging_file = $logging_directory . DIRECTORY_SEPARATOR . Utilities::sanitizeFileName($application->getApplicationName()) . date('Y-m-d') . '.log';