CHANGELOG.md

@@ -5,36 +5,6 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [2.0.7] - 2025-01-13
-
-This update introduces a minor fix
-
-### Fixed
- - Fixed FileLogging issue by setting the write permission to 0666 for the log file if it doesn't exist.
-
-
-
-## [2.0.6] - 2025-01-10
-
-This update introduces a minor change
-
-### Changed
- - File logging is disabled for web environments due to instability in file locking, until a better solution is found.
-
-
-## [2.0.5] - 2025-01-09
-
-This update introduces a minor bug fix
-
-### Fixed
- - Refactor file locking to return status and handle failure.
-
-
-## [2.0.4] - 2024-12-04
-
-This update introduces a minor bug fix
-
-
 ## [2.0.3] - 2024-11-05
 
 This update introduces a minor bug fix

project.json

@@ -20,7 +20,7 @@
         "package": "net.nosial.loglib",
         "company": "Nosial",
         "copyright": "Copyright (c) 2022-2023 Nosial",
-        "version": "2.0.7",
+        "version": "2.0.3",
         "uuid": "de1deca6-7b65-11ed-a8b0-a172264634d8"
     },
     "build": {

src/LogLib/Classes/FileLock.php

@@ -32,11 +32,8 @@
             // Create the file if it doesn't exist
             if (!file_exists($filePath))
             {
-                // Create the file
-                touch($filePath);
-
-                // Set the file permissions to 0666
-                chmod($filePath, 0666);
+                $this->fileHandle = fopen($filePath, 'w');
+                fclose($this->fileHandle);
             }
         }
 
@@ -45,12 +42,12 @@
          *
          * @throws RuntimeException if unable to open or lock the file.
          */
-        private function lock(): bool
+        private function lock(): void
         {
-            $this->fileHandle = @fopen($this->filePath, 'a');
+            $this->fileHandle = fopen($this->filePath, 'a');
             if ($this->fileHandle === false)
             {
-                return false;
+                throw new RuntimeException("Unable to open the file: " . $this->filePath);
             }
 
             // Keep trying to acquire the lock until it succeeds
@@ -67,8 +64,6 @@
                 flock($this->fileHandle, LOCK_UN);
                 $this->lock();
             }
-
-            return true;
         }
 
         /**
@@ -92,11 +87,7 @@
          */
         public function append(string $data): void
         {
-            if(!$this->lock())
-            {
-                // Do not proceed if the file cannot be locked
-                return;
-            }
+            $this->lock();
 
             if ($this->fileHandle !== false)
             {

src/LogLib/Handlers/ConsoleLogging.php

@@ -24,6 +24,7 @@ class ConsoleLogging implements LogHandlerInterface
      */
     public static function handle(Application $application, Event $event): void
     {
+        // Check if the application is running in a CLI environment, if not, return
         if(!Utilities::runningInCli())
         {
             return;
@@ -207,10 +208,7 @@ class ConsoleLogging implements LogHandlerInterface
             print('Stack Trace:' . PHP_EOL);
             foreach($trace as $item)
             {
-                if(isset($item['file']) && isset($item['line']))
-                {
-                    print( ' - ' . self::color($item['file'], ConsoleColors::RED) . ':' . $item['line'] . PHP_EOL);
-                }
+                print( ' - ' . self::color($item['file'], ConsoleColors::RED) . ':' . $item['line'] . PHP_EOL);
             }
         }
 

src/LogLib/Handlers/FileLogging.php

@@ -88,9 +88,9 @@ class FileLogging implements LogHandlerInterface
 
         $logging_file = $logging_directory . DIRECTORY_SEPARATOR . Utilities::sanitizeFileName($application->getApplicationName()) . '-' . date('Y-m-d') . '.log';
 
-        if(!file_exists($logging_file) && !@touch($logging_file))
+        if(!file_exists($logging_file))
         {
-            throw new RuntimeException(sprintf("Cannot write to %s due to insufficient permissions", $logging_file));
+            touch($logging_file);
         }
 
         return $logging_file;
@@ -133,10 +133,7 @@ class FileLogging implements LogHandlerInterface
             $output .= 'Stack Trace:' . PHP_EOL;
             foreach($trace as $item)
             {
-                if(isset($item['file']) && isset($item['line']))
-                {
-                    $output .=  ' - ' . $item['file'] . ':' . $item['line'] . PHP_EOL;
-                }
+                $output .=  ' - ' . $item['file'] . ':' . $item['line'] . PHP_EOL;
             }
         }