Nosial/ncc
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 11 Packages Wiki Activity Actions

Improve error handling for compiler extensions

Browse source
This commit is contained in:
netkas 2024-09-18 15:20:04 -04:00
parent 3160ddfa27
commit 3adc1b81fb
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/ncc/Objects/ProjectConfiguration/Compiler.php
View file

@ -103,7 +103,6 @@
*/
public function getExtension(): CompilerExtensions
{
// TODO: Update usages from here
return $this->extension;
}
@ -243,9 +242,12 @@
throw new ConfigurationException('The property \'project.compiler.extension\' must not be null.');
}
return new self(Functions::array_bc($data, 'extension'),
Functions::array_bc($data, 'maximum_version'),
Functions::array_bc($data, 'minimum_version')
);
$extension = CompilerExtensions::tryFrom(Functions::array_bc($data, 'extension'));
if($extension === null)
{
throw new ConfigurationException('The property \'project.compiler.extension\' is not a valid extension');
}
return new self($extension, Functions::array_bc($data, 'maximum_version'), Functions::array_bc($data, 'minimum_version'));
}
}