From 6482d06ba2718305b937df497ac5377b8d0199bf Mon Sep 17 00:00:00 2001 From: netkas Date: Sat, 14 Sep 2024 09:08:21 -0400 Subject: [PATCH] Fixed Division by zero in PackageManager --- CHANGELOG.md | 3 +++ src/ncc/Managers/PackageManager.php | 5 ++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b5612c..1197ac8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,9 @@ This update introduces a refactored code-base, code quality improvements, and be - Convert NccBuildFlags constants to enum cases - Convert ComponentFlags constants to enum cases +### Fixed + - Fixed Division by zero in PackageManager + ### Removed - Removed EncoderType enum file, unused. - Removed PackageStandardVersions.php diff --git a/src/ncc/Managers/PackageManager.php b/src/ncc/Managers/PackageManager.php index 3dc9487..822e924 100644 --- a/src/ncc/Managers/PackageManager.php +++ b/src/ncc/Managers/PackageManager.php @@ -897,12 +897,12 @@ ]); curl_setopt($curl, CURLOPT_PROGRESSFUNCTION, static function ($resource, $download_size, $downloaded) use ($url, &$end, $progress_bar) { - if($download_size === $downloaded && $end) + if($download_size == 0) { return; } - if($download_size === 0) + if($download_size === $downloaded && $end) { return; } @@ -917,7 +917,6 @@ $progress_bar->setMaxValue($download_size); $progress_bar->setValue($downloaded); $progress_bar->setMiscText(sprintf('%s/%s', $downloaded, $download_size)); - $progress_bar->update(); }