Nosial/ncc
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 11 Packages Wiki Activity Actions

Removed redundant call

Browse source
This commit is contained in:
Netkas 2023-10-01 14:03:06 -04:00
parent f2b69253ae
commit 67956d3641
No known key found for this signature in database
GPG key ID: 5DAF58535614062B
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ncc/Classes/NccExtension/NccCompiler.php
View file

@ -92,11 +92,6 @@
$configuration->setOptions(array_merge($configuration->getOptions(), $options)); $configuration->setOptions(array_merge($configuration->getOptions(), $options));
$static_dependencies = isset($configuration->getOptions()[BuildConfigurationOptions::STATIC_DEPENDENCIES]); $static_dependencies = isset($configuration->getOptions()[BuildConfigurationOptions::STATIC_DEPENDENCIES]);
if(count($options) > 0)
{
$configuration->setOptions(array_merge($configuration->getOptions(), $options));
}
if(isset($configuration->getOptions()[BuildConfigurationOptions::OUTPUT_FILE])) if(isset($configuration->getOptions()[BuildConfigurationOptions::OUTPUT_FILE]))
{ {
$package_path = ConstantCompiler::compileConstants( $package_path = ConstantCompiler::compileConstants(

12
src/ncc/Objects/ProjectConfiguration/Build.php
View file

@ -212,6 +212,18 @@
return array_merge($this->options, $this->getBuildConfiguration($build_configuration)->getOptions()); return array_merge($this->options, $this->getBuildConfiguration($build_configuration)->getOptions());
} }
/**
* Returns the value of a build option property
*
* @param string $property
* @param string|null $build_configuration
* @return mixed
*/
public function getOption(string $property, ?string $build_configuration=null): mixed
{
return $this->getOptions($build_configuration)[$property] ?? null;
}
/** /**
* @param array $options * @param array $options
*/ */