diff --git a/src/ncc/Classes/NccExtension/NccCompiler.php b/src/ncc/Classes/NccExtension/NccCompiler.php index e788ca5..2e4b091 100644 --- a/src/ncc/Classes/NccExtension/NccCompiler.php +++ b/src/ncc/Classes/NccExtension/NccCompiler.php @@ -87,7 +87,6 @@ * @throws PathNotFoundException * @noinspection UnusedFunctionResultInspection */ - // TODO: $build_configuration could use enum case public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string { $configuration = $this->project_manager->getProjectConfiguration()->getBuild()->getBuildConfiguration($build_configuration); @@ -328,7 +327,6 @@ * @param string $build_configuration * @return void */ - // TODO: $build_configuration could use the enum case public function processMetadata(PackageWriter $package_writer, string $build_configuration=BuildConfigurationValues::DEFAULT->value): void { $metadata = new Metadata($this->project_manager->getProjectConfiguration()->getProject()->getCompiler()); diff --git a/src/ncc/Interfaces/CompilerInterface.php b/src/ncc/Interfaces/CompilerInterface.php index 8225603..4081a2a 100644 --- a/src/ncc/Interfaces/CompilerInterface.php +++ b/src/ncc/Interfaces/CompilerInterface.php @@ -41,6 +41,5 @@ * @param array $options Optional. The options to use/override for this build * @return string */ - // TODO: $build_configuration could use the enum case directly public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string; } \ No newline at end of file