From a995732ff7d18a7529dbc92670ff121585eb13d4 Mon Sep 17 00:00:00 2001
From: Netkas <zixing.narrakas1996@gmail.com>
Date: Mon, 2 Jan 2023 19:50:19 -0500
Subject: [PATCH] Improved logging in \ncc\Classes > GitClient

---
 src/ncc/Classes/GitClient.php | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/ncc/Classes/GitClient.php b/src/ncc/Classes/GitClient.php
index c7daca4..cef173d 100644
--- a/src/ncc/Classes/GitClient.php
+++ b/src/ncc/Classes/GitClient.php
@@ -22,6 +22,7 @@
          */
         public static function cloneRepository(string $url): string
         {
+            Console::outVerbose('Cloning repository: ' . $url);
             $path = Functions::getTmpDir();
             $process = new Process(["git", "clone", $url, $path]);
             $process->setTimeout(3600); // 1 hour
@@ -33,7 +34,8 @@
             if (!$process->isSuccessful())
                 throw new GitCloneException($process->getErrorOutput());
 
-            Console::outVerbose('Repository cloned to ' . $path);
+            Console::outVerbose('Repository cloned to: ' . $path);
+
             return $path;
         }
 
@@ -46,6 +48,7 @@
          */
         public static function checkout(string $path, string $branch)
         {
+            Console::outVerbose('Checking out branch' . $branch);
             $process = new Process(["git", "checkout", $branch], $path);
             $process->setTimeout(3600); // 1 hour
             $process->run(function ($type, $buffer)
@@ -63,7 +66,7 @@
             if (!$process->isSuccessful())
                 throw new GitCheckoutException($process->getErrorOutput());
 
-            Console::outVerbose('Checked out branch ' . $branch);
+            Console::outVerbose('Checked out branch: ' . $branch);
         }
 
         /**
@@ -75,6 +78,7 @@
          */
         public static function getTags(string $path): array
         {
+            Console::outVerbose('Getting tags for repository: ' . $path);
             $process = new Process(["git", "fetch", '--all', '--tags'] , $path);
             $process->setTimeout(3600); // 1 hour
             $process->run(function ($type, $buffer)
@@ -96,6 +100,12 @@
                 throw new GitTagsException($process->getErrorOutput());
 
             $tags = explode(PHP_EOL, $process->getOutput());
+            $tags = array_filter($tags, function ($tag)
+            {
+                return !empty($tag);
+            });
+
+            Console::outDebug('found ' . count($tags) . ' tags');
             return array_filter($tags);
         }