Nosial/ncc

[Bug] Merging already merged dependencies #52

New issue

Closed

opened 2023-10-18 17:56:27 +00:00 by netkas · 3 comments

netkas commented

2023-10-18 17:56:27 +00:00

(Migrated from git-old.n64.cc)

When building a binary package file using “ncc build” to produce a static build, when merging dependencies ncc doesn’t keep track or check if the dependency is already merged into the package, resulting in the merge function be called to attempt to merge the same dependency again.

When building a binary package file using “ncc build” to produce a static build, when merging dependencies ncc doesn’t keep track or check if the dependency is already merged into the package, resulting in the merge function be called to attempt to merge the same dependency again.

netkas commented

2023-10-18 17:56:28 +00:00

(Migrated from git-old.n64.cc)

assigned to @netkas

assigned to @netkas

netkas commented

2023-10-18 17:57:33 +00:00

(Migrated from git-old.n64.cc)

This doesn’t produce an error but increases the build time. Adding this check will reduce the build time

This doesn’t produce an error but increases the build time. Adding this check will reduce the build time

netkas commented

2023-10-18 19:58:51 +00:00

(Migrated from git-old.n64.cc)

Fixed in #89d3af8680cdf48b99f2138e57e84eb2bac0ecb2

Fixed in [#89d3af8680cdf48b99f2138e57e84eb2bac0ecb2](https://git.n64.cc/nosial/ncc/-/commit/89d3af8680cdf48b99f2138e57e84eb2bac0ecb2)

netkas (Migrated from git-old.n64.cc) closed this issue

2023-10-18 19:59:03 +00:00

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Nosial/ncc#52

No description provided.