Nosial/socialbox-php
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Refactor session handling in policy acceptance methods.

Browse source
This commit is contained in:
netkas 2025-01-06 02:17:49 -05:00
parent da250d6189
commit 3a72363937
2 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/Socialbox/Classes/StandardMethods/AcceptCommunityGuidelines.php
View file

@ -21,7 +21,8 @@
*/ */
public static function execute(ClientRequest $request, RpcRequest $rpcRequest): ?SerializableInterface public static function execute(ClientRequest $request, RpcRequest $rpcRequest): ?SerializableInterface
{ {
if(!$request->getSession()->flagExists(SessionFlags::VER_COMMUNITY_GUIDELINES)) $session = $request->getSession();
if(!$session->flagExists(SessionFlags::VER_COMMUNITY_GUIDELINES))
{ {
return $rpcRequest->produceError(StandardError::FORBIDDEN, 'Community guidelines has already been accepted'); return $rpcRequest->produceError(StandardError::FORBIDDEN, 'Community guidelines has already been accepted');
} }
@ -29,7 +30,7 @@
try try
{ {
// Check & update the session flow // Check & update the session flow
SessionManager::updateFlow($request->getSession(), [SessionFlags::VER_COMMUNITY_GUIDELINES]); SessionManager::updateFlow($session, [SessionFlags::VER_COMMUNITY_GUIDELINES]);
} }
catch (DatabaseOperationException $e) catch (DatabaseOperationException $e)
{ {

14
src/Socialbox/Classes/StandardMethods/AcceptPrivacyPolicy.php
View file

@ -13,19 +13,23 @@
class AcceptPrivacyPolicy extends Method class AcceptPrivacyPolicy extends Method
{ {
/** /**
* Executes the process of accepting the privacy policy.
*
* @inheritDoc * @inheritDoc
*/ */
public static function execute(ClientRequest $request, RpcRequest $rpcRequest): ?SerializableInterface public static function execute(ClientRequest $request, RpcRequest $rpcRequest): ?SerializableInterface
{ {
$session = $request->getSession();
if(!$session->flagExists(SessionFlags::VER_PRIVACY_POLICY))
{
return $rpcRequest->produceError(StandardError::FORBIDDEN, 'Privacy policy has already been accepted');
}
try try
{ {
// Remove the verification flag
SessionManager::removeFlags($request->getSessionUuid(), [SessionFlags::VER_PRIVACY_POLICY]);
// Check & update the session flow // Check & update the session flow
SessionManager::updateFlow($request->getSession()); SessionManager::updateFlow($session, [SessionFlags::VER_PRIVACY_POLICY]);
} }
catch (DatabaseOperationException $e) catch (DatabaseOperationException $e)
{ {