From 5cb8e72ca5ab1ce3cf09bbb32ea36a93d8ef58ad Mon Sep 17 00:00:00 2001 From: netkas Date: Tue, 14 Jan 2025 15:45:17 -0500 Subject: [PATCH] Refactor header validation logic. --- src/Socialbox/Socialbox.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Socialbox/Socialbox.php b/src/Socialbox/Socialbox.php index 703e05a..52ae74f 100644 --- a/src/Socialbox/Socialbox.php +++ b/src/Socialbox/Socialbox.php @@ -122,12 +122,6 @@ return false; } - if(!$clientRequest->headerExists(StandardHeaders::SIGNING_PUBLIC_KEY)) - { - self::returnError(400, StandardError::BAD_REQUEST, 'Missing required header: ' . StandardHeaders::SIGNING_PUBLIC_KEY->value); - return false; - } - if(!$clientRequest->headerExists(StandardHeaders::ENCRYPTION_PUBLIC_KEY)) { self::returnError(400, StandardError::BAD_REQUEST, 'Missing required header: ' . StandardHeaders::ENCRYPTION_PUBLIC_KEY->value); @@ -146,6 +140,12 @@ return false; } + if(!$clientRequest->getIdentifyAs()->isExternal() && !$clientRequest->headerExists(StandardHeaders::SIGNING_PUBLIC_KEY)) + { + self::returnError(400, StandardError::BAD_REQUEST, 'Missing required header: ' . StandardHeaders::SIGNING_PUBLIC_KEY->value); + return false; + } + return true; }