Nosial/socialbox-php
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Refactor AddressBookGetContact to streamline peer address validation and response handling

Browse source 
https://github.com/nosial/Socialbox-PHP/issues/33
This commit is contained in:
netkas 2025-03-11 19:23:31 -04:00
parent 1c48fcd35e
commit 8cd3b381cf
Signed by: netkas
GPG key ID: 4D8629441B76E4CC
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/Socialbox/Classes/StandardMethods/AddressBook/AddressBookGetContact.php
View file

@ -29,24 +29,16 @@
throw new MissingRpcArgumentException('peer'); throw new MissingRpcArgumentException('peer');
} }
try
{
$address = PeerAddress::fromAddress($rpcRequest->getParameter('peer')); $address = PeerAddress::fromAddress($rpcRequest->getParameter('peer'));
}
catch(InvalidArgumentException $e)
{
throw new InvalidRpcArgumentException('peer', $e);
}
try try
{ {
if(!ContactManager::isContact($request->getPeer(), $address)) if(!ContactManager::isContact($request->getPeer(), $address))
{ {
// Return empty response if the contact does not exist
return $rpcRequest->produceResponse(); return $rpcRequest->produceResponse();
} }
$rpcRequest->produceResponse(ContactManager::getStandardContact($request->getPeer(), $address)); return $rpcRequest->produceResponse(ContactManager::getStandardContact($request->getPeer(), $address));
} }
catch(DatabaseOperationException $e) catch(DatabaseOperationException $e)
{ {