Nosial/socialbox-php
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Refactor ResolvePeer to improve peer address handling by removing unnecessary exception handling and ensuring proper type casting for the peer parameter.

Browse source 
https://github.com/nosial/Socialbox-PHP/issues/43
This commit is contained in:
netkas 2025-03-13 00:25:13 -04:00
parent 3be5cd104d
commit df96d894a8
Signed by: netkas
GPG key ID: 4D8629441B76E4CC
1 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/Socialbox/Classes/StandardMethods/Core/ResolvePeer.php
View file

@ -2,7 +2,6 @@
namespace Socialbox\Classes\StandardMethods\Core;
use InvalidArgumentException;
use Socialbox\Abstracts\Method;
use Socialbox\Enums\ReservedUsernames;
use Socialbox\Enums\StandardError;
@ -30,20 +29,13 @@
}
// Parse the peer address
try
{
$peerAddress = PeerAddress::fromAddress($rpcRequest->getParameter('peer'));
}
catch(InvalidArgumentException $e)
{
throw new StandardRpcException('Peer Address Error: ' . $e->getMessage(), StandardError::RPC_INVALID_ARGUMENTS, $e);
}
$peerAddress = PeerAddress::fromAddress((string)$rpcRequest->getParameter('peer'));
// Check if host is making the request & the identifier is not empty
try
{
$identifyAs = null;
if ($request->getPeer()->getUsername() == ReservedUsernames::HOST && $request->getIdentifyAs() != null)
if ($request->getPeer()->getUsername() === ReservedUsernames::HOST->value && $request->getIdentifyAs() !== null)
{
$identifyAs = $request->getIdentifyAs();
}