Increase UDP buffer size and adjust recvfrom limit in UDP server

docker/logger.py

@@ -303,12 +303,13 @@ class MultiProtocolServer:
 
     def _start_udp_server(self):
         with socket.socket(socket.AF_INET, socket.SOCK_DGRAM) as udp_socket:
+            udp_socket.setsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF, 1024 * 1024)
             udp_socket.bind((self.host, self.port))
             self.logger.debug(f"UDP server running on {self.host}:{self.port}")
 
             while not self.stop_event.is_set():
                 try:
-                    data, address = udp_socket.recvfrom(4096)
+                    data, address = udp_socket.recvfrom(65535)
                     self._handle_udp_client(data, address)
                 except Exception as e:
                     self.logger.error(f"UDP server error: {e}")

src/Socialbox/Classes/RpcClient.php

@@ -59,6 +59,10 @@
         public function __construct(string|PeerAddress $identifiedAs, ?string $server=null, ?ExportedSession $exportedSession=null)
         {
             $this->logger = new \LogLib2\Logger('net.nosial.socialbox');
+            if($server !== null)
+            {
+                $server = strtolower($server);
+            }
 
             // If an exported session is provided, no need to re-connect.
             // Just use the session details provided.

src/Socialbox/Managers/ExternalSessionManager.php

@@ -20,6 +20,8 @@
          */
         public static function sessionExists(string $domain): bool
         {
+            $domain = strtolower($domain);
+
             try
             {
                 $stmt = Database::getConnection()->prepare("SELECT COUNT(*) FROM external_sessions WHERE domain=:domain LIMIT 1");
@@ -47,7 +49,7 @@
             try
             {
                 $stmt = Database::getConnection()->prepare("INSERT INTO external_sessions (domain, rpc_endpoint, session_uuid, transport_encryption_algorithm, server_keypair_expires, server_public_signing_key, server_public_encryption_key, host_public_encryption_key, host_private_encryption_key, private_shared_secret, host_transport_encryption_key, server_transport_encryption_key) VALUES (:domain, :rpc_endpoint, :session_uuid, :transport_encryption_algorithm, :server_keypair_expires, :server_public_signing_key, :server_public_encryption_key, :host_public_encryption_key, :host_private_encryption_key, :private_shared_secret, :host_transport_encryption_key, :server_transport_encryption_key)");
-                $domain = $exportedSession->getRemoteServer();
+                $domain = strtolower($exportedSession->getRemoteServer());
                 $stmt->bindParam(':domain', $domain);
                 $rpcEndpoint = $exportedSession->getRpcEndpoint();
                 $stmt->bindParam(':rpc_endpoint', $rpcEndpoint);
@@ -89,6 +91,8 @@
          */
         public static function getSession(string $domain): ?ExportedSession
         {
+            $domain = strtolower($domain);
+
             try
             {
                 $stmt = Database::getConnection()->prepare("SELECT * FROM external_sessions WHERE domain=:domain LIMIT 1");
@@ -134,6 +138,8 @@
          */
         public static function removeSession(string $domain): void
         {
+            $domain = strtolower($domain);
+
             try
             {
                 $stmt = Database::getConnection()->prepare("DELETE FROM external_sessions WHERE domain=:domain");
@@ -156,6 +162,8 @@
          */
         public static function updateLastAccessed(string $domain): void
         {
+
+
             try
             {
                 $stmt = Database::getConnection()->prepare("UPDATE external_sessions SET last_accessed=CURRENT_TIMESTAMP WHERE domain=:domain");

src/Socialbox/Socialbox.php

@@ -734,6 +734,8 @@
          */
         public static function getExternalSession(string $domain): SocialClient
         {
+            $domain = strtolower($domain);
+
             if(ExternalSessionManager::sessionExists($domain))
             {
                 return new SocialClient(self::getServerAddress(), $domain, ExternalSessionManager::getSession($domain));
@@ -749,6 +751,11 @@
                 throw new ResolutionException(sprintf('Failed to connect to remote server %s: %s', $domain, $e->getMessage()), $e->getCode(), $e);
             }
 
+            if(!$client->getSessionState()->isAuthenticated())
+            {
+                throw new ResolutionException(sprintf('Failed to authenticate with remote server %s', $domain));
+            }
+
             ExternalSessionManager::addSession($client->exportSession());
             return $client;
         }

tests/Socialbox/AddressBookTest.php

@@ -688,12 +688,14 @@
         public function testCaseInsensitiveContactAddress(): void
         {
             $johnClient = Helper::generateRandomClient(TEAPOT_DOMAIN, prefix: 'johnCaseTest');
-            $johnClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'John Doe');
+            $this->assertTrue($johnClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'John Doe'));
-            $johnClient->settingsSetPassword('SecretTestingPassword123');
+            $this->assertTrue($johnClient->settingsSetPassword('SecretTestingPassword123'));
+            $this->assertTrue($johnClient->getSessionState()->isAuthenticated());
 
             $aliceClient = Helper::generateRandomClient(COFFEE_DOMAIN, prefix: 'aliceCaseTest');
-            $aliceClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'Alice Smith');
+            $this->assertTrue($aliceClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'Alice Smith'));
-            $aliceClient->settingsSetPassword('SecretTestingPassword123');
+            $this->assertTrue($aliceClient->settingsSetPassword('SecretTestingPassword123'));
+            $this->assertTrue($aliceClient->getSessionState()->isAuthenticated());
             $aliceAddress = $aliceClient->getIdentifiedAs();
             $mixedCaseAddress = ucfirst(strtolower($aliceAddress->getUsername())).'@'.strtoupper($aliceAddress->getDomain());
 

tests/Socialbox/SettingsTest.php

@@ -4,6 +4,7 @@
 
     use Helper;
     use PHPUnit\Framework\TestCase;
+    use Socialbox\Enums\Flags\SessionFlags;
     use Socialbox\Enums\PrivacyState;
     use Socialbox\Enums\Types\InformationFieldName;
     use Socialbox\Exceptions\CryptographyException;
@@ -512,4 +513,43 @@
             $this->assertTrue($aliceResolved->informationFieldExists(InformationFieldName::DISPLAY_NAME));
             $this->assertEquals('Alice Smith', $aliceResolved->getInformationField(InformationFieldName::DISPLAY_NAME)->getValue());
         }
+
+        /**
+         * @throws RpcException
+         * @throws ResolutionException
+         * @throws CryptographyException
+         * @throws DatabaseOperationException
+         */
+        public function testDeleteRequiredPassword(): void
+        {
+            $testClient = Helper::generateRandomClient(COFFEE_DOMAIN, prefix: 'deleteRequiredPassword');
+            $this->assertTrue($testClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'John Doe'));
+            $this->assertTrue($testClient->settingsSetPassword('SecretTestingPassword123'));
+            $this->assertTrue($testClient->getSessionState()->isAuthenticated());
+
+            $this->expectException(RpcException::class);
+            $testClient->settingsDeletePassword();
+        }
+
+        /**
+         * @throws RpcException
+         * @throws DatabaseOperationException
+         * @throws ResolutionException
+         * @throws CryptographyException
+         */
+        public function testSettingsSetOtp(): void
+        {
+            $testClient = Helper::generateRandomClient(COFFEE_DOMAIN, prefix: 'testSetOtp');
+            $testAddress = $testClient->getIdentifiedAs();
+            $this->assertTrue($testClient->settingsAddInformationField(InformationFieldName::DISPLAY_NAME, 'John Doe'));
+            $this->assertTrue($testClient->settingsSetPassword('SecretTestingPassword123'));
+            $this->assertTrue($testClient->getSessionState()->isAuthenticated());
+
+            $secret = $testClient->settingsSetOtp('SecretTestingPassword123');
+            $this->assertNotEmpty($secret);
+
+            $testClient = new SocialClient($testAddress);
+            $this->assertFalse($testClient->getSessionState()->isAuthenticated());
+            $this->assertTrue($testClient->getSessionState()->containsFlag(SessionFlags::VER_OTP));
+        }
     }