Compare commits

...
Sign in to create a new pull request.

2 commits

Author SHA1 Message Date
netkas
ec6e58c8ec Allow nullable type for MessageEntity type 2024-12-04 13:31:53 -05:00
netkas
9a5a593789 Refactor PollingBot to use PsyncLib for updates 2024-12-04 00:45:19 -05:00
4 changed files with 40 additions and 123 deletions

View file

@ -36,6 +36,12 @@
"version": "latest",
"source_type": "remote",
"source": "nosial/libs.opts=latest@n64"
},
{
"name": "net.nosial.psynclib",
"version": "latest",
"source_type": "remote",
"source": "nosial/libs.psync=latest@n64"
}
],
"configurations": [

View file

@ -504,6 +504,20 @@
}
}
/**
* Processes an array of updates.
*
* @param array $updates An array containing update objects to be handled. Each update will be individually processed by calling the handleUpdate method.
* @return void This method does not return a value.
*/
public function handleUpdates(array $updates): void
{
foreach($updates as $update)
{
$this->handleUpdate($update);
}
}
/**
* Sends a request by executing the specified method with the given parameters.
*

View file

@ -7,7 +7,7 @@
class MessageEntity implements ObjectTypeInterface
{
private MessageEntityType $type;
private ?MessageEntityType $type;
private int $offset;
private int $length;
private ?string $url;
@ -23,9 +23,9 @@
* (monowidth block), “text_link” (for clickable text URLs), “text_mention” (for users without usernames),
* “custom_emoji” (for inline custom emoji stickers)
*
* @return MessageEntityType
* @return ?MessageEntityType
*/
public function getType(): MessageEntityType
public function getType(): ?MessageEntityType
{
return $this->type;
}
@ -33,10 +33,10 @@
/**
* Sets the type of the entity
*
* @param MessageEntityType $type
* @param ?MessageEntityType $type
* @return MessageEntity
*/
public function setType(MessageEntityType $type): MessageEntity
public function setType(?MessageEntityType $type): MessageEntity
{
$this->type = $type;
return $this;
@ -223,7 +223,7 @@
}
$object = new self();
$object->type = MessageEntityType::tryFrom($data['type']);
$object->type = is_null($data['type']) ? null : MessageEntityType::tryFrom($data['type']);
$object->offset = $data['offset'] ?? null;
$object->length = $data['length'] ?? null;
$object->url = $data['url'] ?? null;

View file

@ -2,8 +2,7 @@
namespace TgBotLib;
use RuntimeException;
use function RuntimeException;
use PsyncLib\Psync;
/**
* PollingBot class that extends Bot for handling updates using polling.
@ -14,8 +13,6 @@
private int $limit;
private int $timeout;
private array $allowedUpdates;
private bool $fork;
private array $childPids;
/**
* Constructor for the class, initializing with a Bot instance.
@ -30,8 +27,6 @@
$this->limit = 100;
$this->timeout = 0;
$this->allowedUpdates = [];
$this->fork = false;
$this->childPids = [];
// Register signal handler for child processes
if (function_exists('pcntl_signal'))
@ -115,6 +110,11 @@
$this->allowedUpdates = $allowedUpdates;
}
/**
* Retrieves the list of allowed updates.
*
* @return array Returns an array containing the allowed updates.
*/
public function getAllowedUpdates(): array
{
return $this->allowedUpdates;
@ -137,55 +137,14 @@
}
/**
* Sets the fork value.
* Polls for updates and processes them. Installs a signal handler if
* needed, fetches updates, tracks the highest update ID, updates the
* polling offset, and handles the updates using the Psync mechanism.
*
* @param bool $fork The fork value to set.
* @return void
* @return void This method does not return any value.
*/
public function setFork(bool $fork): void
public function poll(): void
{
$this->fork = $fork;
}
/**
* Retrieves the current fork setting.
*
* @return bool The configured fork value.
*/
public function getFork(): bool
{
return $this->fork;
}
private function signalHandler(int $signal): void
{
if ($signal === SIGCHLD)
{
$i = -1;
while (($pid = pcntl_wait($i, WNOHANG)) > 0)
{
$key = array_search($pid, $this->childPids);
if ($key !== false)
{
unset($this->childPids[$key]);
}
}
}
}
/**
* Handles incoming updates by fetching and processing them with appropriate event handlers.
*
* @return void
*/
public function handleUpdates(): void
{
// Install signal handler
if ($this->fork && function_exists('pcntl_signal_dispatch'))
{
pcntl_signal_dispatch();
}
$updates = $this->getUpdates(offset: ($this->offset ?: 0), limit: $this->limit, timeout: $this->timeout, allowed_updates: $this->retrieveAllowedUpdates());
if (empty($updates))
@ -195,7 +154,6 @@
// Track the highest update ID we've seen
$maxUpdateId = null;
foreach ($updates as $update)
{
// Update the maximum update ID as we go
@ -203,56 +161,6 @@
{
$maxUpdateId = $update->getUpdateId();
}
if ($this->fork)
{
// Clean up any finished processes
if (function_exists('pcntl_signal_dispatch'))
{
pcntl_signal_dispatch();
}
$pid = pcntl_fork();
if ($pid == -1)
{
// Fork failed
throw new RuntimeException('Failed to fork process for update handling');
}
elseif ($pid)
{
// Parent process
$this->childPids[] = $pid;
// If we have too many child processes, wait for some to finish
$maxChildren = 32; // Adjust this value based on your system's capabilities
while (count($this->childPids) >= $maxChildren)
{
if (function_exists('pcntl_signal_dispatch'))
{
pcntl_signal_dispatch();
}
usleep(10000); // Sleep for 10ms to prevent CPU hogging
}
}
else
{
// Child process
try
{
$this->handleUpdate($update);
}
finally
{
exit(0);
}
}
}
else
{
$this->handleUpdate($update);
}
}
// Update the offset based on the highest update ID we've seen
@ -261,20 +169,9 @@
$this->offset = $maxUpdateId + 1;
}
// If forking is enabled, ensure we clean up any remaining child processes
if ($this->fork)
{
// Wait for remaining child processes to finish
while (!empty($this->childPids))
{
if (function_exists('pcntl_signal_dispatch'))
{
pcntl_signal_dispatch();
}
usleep(10000); // Sleep for 10ms to prevent CPU hogging
}
}
// Pass the method name as a string and the object
Psync::do([$this, 'handleUpdates'], [$updates]);
Psync::clean();
}
/**