Nosial/ncc
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases 11 Packages Wiki Activity Actions

Removed todos (for now)

Browse source
This commit is contained in:
netkas 2024-09-17 22:08:55 -04:00
parent d0e484631f
commit 7e224d91b2
2 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ncc/Classes/NccExtension/NccCompiler.php
View file

@ -87,7 +87,6 @@
* @throws PathNotFoundException * @throws PathNotFoundException
* @noinspection UnusedFunctionResultInspection * @noinspection UnusedFunctionResultInspection
*/ */
// TODO: $build_configuration could use enum case
public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string
{ {
$configuration = $this->project_manager->getProjectConfiguration()->getBuild()->getBuildConfiguration($build_configuration); $configuration = $this->project_manager->getProjectConfiguration()->getBuild()->getBuildConfiguration($build_configuration);
@ -328,7 +327,6 @@
* @param string $build_configuration * @param string $build_configuration
* @return void * @return void
*/ */
// TODO: $build_configuration could use the enum case
public function processMetadata(PackageWriter $package_writer, string $build_configuration=BuildConfigurationValues::DEFAULT->value): void public function processMetadata(PackageWriter $package_writer, string $build_configuration=BuildConfigurationValues::DEFAULT->value): void
{ {
$metadata = new Metadata($this->project_manager->getProjectConfiguration()->getProject()->getCompiler()); $metadata = new Metadata($this->project_manager->getProjectConfiguration()->getProject()->getCompiler());

1
src/ncc/Interfaces/CompilerInterface.php
View file

@ -41,6 +41,5 @@
* @param array $options Optional. The options to use/override for this build * @param array $options Optional. The options to use/override for this build
* @return string * @return string
*/ */
// TODO: $build_configuration could use the enum case directly
public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string; public function build(string $build_configuration=BuildConfigurationValues::DEFAULT->value, array $options=[]): string;
} }